Gallipoli has been mentioned, but not as a bad film if that's what you mean.

Little Hawk, they showed "Son of the Morning Star" when I was about 8, very good, I especially remember the scene where they cut his hair. Another entertaining Flynn war film is "The Charge of the Light Brigade". Terrible history, but a great romp and the costumes aren't too bad, considering. I was impressed by the Turcomans.

The songs in "Oh, What a Lovely War!" are modern, but using old tunes. Wonderful piece of absurdity.