When this Bloody War is Over is from the Great War. The reference to 'standing to in trenches', 'standing on the firestep' and 'Tickler's marmalade' in the third verse all relate to trench warfare on the Western Front. There's also a clue in the title of Max Arthur's book -

When This Bloody War is Over: Soldiers' Songs of the First World War