But would the question "when did you decide to be a non-smoker?" be a very effective way of challenging the idea that smoking is a choice?

Apples and Oranges.
Sexuality is an inherent part of our being. Putting a piece of burning tobacco wrapped in paper to your lips and inhaling is not.