Basically, I think 'Scotch' should operate as an adjective, and 'Scot' as a noun....thus "Scotch Whiskey" which was invented by "Scots". But once 'Scotch' began to be used as a noun by itself, it all began to sound strange.
In the Burns quote, it is used each time to modify a noun.