Steve, I looked into the song's background for Gwilym, and my findings match yours precisely.

"Jack Spade" may be a pseudonym. It is possible that he or someone he knew actually did write the song during WW1 or not long afterward, but there is no trace of it before 1944, and no evidence that it was known at all, if it existed at all, in 1915-18.